[ENH] Test widgets on travis #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2016
Current coverage is 87.93%@@ master #1417 diff @@
==========================================
Files 77 77
Lines 7582 7582
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6666 6667 +1
+ Misses 916 915 -1
Partials 0 0
|
astaric
force-pushed
the
gui-tests
branch
2 times, most recently
from
880e87d
to
61b6b8e
Compare
astaric
changed the title
| app.processEvents() | ||
| for w in cls.widgets: | ||
| w.onDeleteWidget() | ||
| sip.delete(w) |
There was a problem hiding this comment.
Does it work if you just put a destructor on OWWidget:
def __del__(self):
if not sip.isdeleted(self):
sip.delete(self)
astaric
changed the title
Keeps track of created widgets and makes sure they are properly disposed, thus avoiding segmentation faults. Provides a simple signal manager that can be used to set inputs and get output values.
astaric
force-pushed
the
gui-tests
branch
2 times, most recently
from
2900244
to
75c01fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for (random) segfaults related to gui tests on travis, as well as (slightly modified) tests from #1262 and #1334.